Discussion:
[PATCH -next] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe()
(too old to reply)
Wei Yongjun
2018-01-17 11:40:34 UTC
Permalink
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <***@huawei.com>
---
drivers/char/hw_random/bcm2835-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index 25e5631..7a84cec 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -158,10 +158,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev)

/* map peripheral */
priv->base = devm_ioremap_resource(dev, r);
- if (IS_ERR(priv->base)) {
- dev_err(dev, "failed to remap rng regs");
+ if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
- }

/* Clock is optional on most platforms */
priv->clk = devm_clk_get(dev, NULL);
Eric Anholt
2018-01-17 19:47:58 UTC
Permalink
Post by Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reviewed-by: Eric Anholt <***@anholt.net>
Florian Fainelli
2018-01-22 23:09:48 UTC
Permalink
Post by Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Acked-by: Florian Fainelli <***@gmail.com>
--
Florian
Herbert Xu
2018-01-26 15:45:24 UTC
Permalink
Post by Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Patch applied. Thanks.
--
Email: Herbert Xu <***@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Loading...